IC4M10: New Wave Attenuation Scheme #1293
Conversation
|
Thank you for submitting this work @erinethomas! One quick question, this is submitted to the |
|
No we meant to put this in the develop branch -the E3SM + CESM community would like to eventually use the 'Develop branch' as our common WW3 code base - which needed the new attenuation method we are both already testing for wave-ice interactions. It looks like the same method was already put in the UFS branch (@NickSzapiro-NOAA - is this the case)? I am unfamiliar with how PRs and new developments get shared/merged between the develop vs UFS branches? |
|
@MatthewMasarik-NOAA This IC4M10 is the same scheme as in dev/ufs-weather-model. Erin will also PR a "numerics" change for how the attenuation is applied for this scheme. If/once approved, our plan was to replace what is in dev/ufs-weather-model with this IC4M10 + numerics change. If that sounds good to you |
|
Okay, thank you for that context @erinethomas @NickSzapiro-NOAA. I will need to look closer into these two PRs. @JessicaMeixner-NOAA had been handling #1211, but will be unavailable for the next few months while on a temporary detail. We have actually needed to post a Temporary PR Policy to adjust for this. Once I've had a chance to spin myself up on all the details I'll report back on how to proceed. |
|
@MatthewMasarik-NOAA - thank you! there is no rush on our (the E3SM/CESM) side - we just wanted to start coordinating our efforts back to the main WW3 repo :) |
Perfect. Thank you. |
|
Hi @erinethomas, I wanted to update the status that we will need to wait to process this till ~November. Sorry for this delay. We're looking forward to reviewing it that point. |
Pull Request Summary
A new wave attenuation scheme (IC4 method 10) based on Meylan Horvat Bitz Bennetts Ocean Modelling 2021
Description
This PR adds a new wave attenuation scheme for IC4. It is based on Meylan Horvat Bitz and Bennetts, Ocean Modelling, 2021. It calculated wave damping based on scattering due to sea ice floes. It requires the use of the IS0 switch (no additional scattering term) and sea ice floe size diameter as input from ICECOEF5.
Suggestions for a reviewers:
Labels that should be added: new feature
Commit Message
IC4M10: New wave damping scheme in sea ice based on Meylan Horvat Bitz and Bennetts, Ocean Modelling, 2021. Co-Authors include: Erin Thomas, Cecilia Bitz, David Bailey, Nick Szapiro.
Check list
Testing
How were these changes tested?
These changes have been tested in fully coupled climate model simulations (E3SM and CESM) which have fully coupled wave (WW3) and sea ice components (the later of which contain sea ice floe size distribution).
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the matrix regression tests been run (if yes, please note HPC and compiler)?
Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):